Open
Conversation
AlvaroBrey
previously approved these changes
Oct 26, 2021
Member
|
Change looks good, but tests are failing |
AndyScherzinger
previously approved these changes
Oct 26, 2021
tobiasKaminsky
dismissed stale reviews from AndyScherzinger and AlvaroBrey
via
1f678bb
tobiasKaminsky
force-pushed
the
sendByMail
branch
3 times, most recently
from
78f9d87 to
8cda379
Compare
Member
Author
@AlvaroBrey do you have an idea why suddenly so many tests on stable, but only on stable, fail? |
Member
It seems that most of the crashes are related to OCCapability. Any recent changes there? |
tobiasKaminsky
force-pushed
the
sendByMail
branch
3 times, most recently
from
20b435d to
1ebf304
Compare
Member
Author
|
All solved except of lint, which complains as another dependency is outdated. |
AlvaroBrey
previously approved these changes
Nov 3, 2021
Member
Author
|
/rebase |
nextcloud-command
force-pushed
the
sendByMail
branch
from
1ebf304 to
46191c6
Compare
AndyScherzinger
force-pushed
the
sendByMail
branch
from
46191c6 to
38ab9d5
Compare
AndyScherzinger
force-pushed
the
sendByMail
branch
from
38ab9d5 to
20c9841
Compare
tobiasKaminsky
force-pushed
the
sendByMail
branch
from
20c9841 to
270f186
Compare
tobiasKaminsky
force-pushed
the
sendByMail
branch
from
270f186 to
c6c209c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
============================================
+ Coverage 49.02% 49.08% +0.05%
- Complexity 1028 1031 +3
============================================
Files 215 215
Lines 8087 8101 +14
Branches 1038 1040 +2
============================================
+ Hits 3965 3976 +11
- Misses 3554 3556 +2
- Partials 568 569 +1
|
Contributor
AndyScherzinger
force-pushed
the
sendByMail
branch
from
c6c209c to
e0b542c
Compare
Contributor
tobiasKaminsky
force-pushed
the
sendByMail
branch
from
e0b542c to
e85aab3
Compare
Contributor
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
sendByMail
branch
from
e85aab3 to
e595288
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me